Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip non numeric value in SUMIF #618

Merged
merged 5 commits into from
Oct 7, 2018
Merged

skip non numeric value in SUMIF #618

merged 5 commits into from
Oct 7, 2018

Conversation

Scorty
Copy link
Contributor

@Scorty Scorty commented Jul 31, 2018 •
edited
Loading

This is:

- [x ] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

MS Excel skip non numeric values also. PhpSpreadsheet fail on string value with: Warning: A non-numeric value encountered

PHP 7.1.18

PowerKiKi
PowerKiKi requested changes Aug 6, 2018
View reviewed changes
Copy link
Member

@PowerKiKi PowerKiKi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This miss unit test to be merged. Could you please add some cases, most likely in tests/data/Calculation/MathTrig/SUMIF.php ?

Also update the CHANGELOG.md

@Scorty
Copy link
Contributor Author

Scorty commented Oct 4, 2018

Sorry but CI failed on file tests that I did not change :-(

@PowerKiKi PowerKiKi merged commit ae9dd13 into PHPOffice:develop Oct 7, 2018
@PowerKiKi
Copy link
Member

Thanks !

@DuckDensity DuckDensity mentioned this pull request Oct 8, 2018
Closed
@DuckDensity DuckDensity mentioned this pull request Oct 25, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerKiKi PowerKiKi PowerKiKi requested changes

Assignees
No one assigned
Labels
missing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scorty @PowerKiKi