Fix #557: Handle escaped spaces in date format would cause incorrect AM/PM conversion #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekthesqueak
changed the title
date format leading to incorrect time conversions
PowerKiKi
requested changes
Jun 21, 2018
|
Thanks ! |
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
Fix issue where escaped spaces in cell format would cause incorrect date format leading to incorrect time conversions Fixes PHPOffice#557 Closes PHPOffice#558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
This custom formatting commonly shows up in exported timesheet data from a large company.
When the escaped space isn't kept it will lead this to the format array being exploded into 3 pieces. Then at https://github.com/PHPOffice/PhpSpreadsheet/blob/1.3.1/src/PhpSpreadsheet/Style/NumberFormat.php#L468 the check only only take the firs block which is 'hh:mm:ss' so it assumes 24 hour but then later in the loop you'll have 'am/pm' which gets converted into A. When all is said and done you can get AM/PM on a 24 hour value.