Properly set selected cells for frozen panes. #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataValidations.
…cEngine_errors' and 'PHPOffice#388-Xlsx_MSextensions' into develop-merges
make newer Excel versions properly recalculate formulas on documents
Develop merges
Fix for issue PHPOffice#523. When reading then writing a Xlsx spreadsheet, preserve the workbook bookview attributes for the spreadsheet, (e.g., the attribute that hides worksheet tabs.) Beforehand, these attributes were always being set to fixed constants.
Issue 523
Made the following changes to fix PHPOffice#523 based on code-review comments. * Updating workbook attributes is now done via a loop. * Unit test no longer requires an input xlsx document.
* Renamed the test script to reflect that it tests all workbook bookview attributes, not just the 'showSheetTabs' attribute. * Rewrote the comment for the test case to indicate that it tests all workbook bookvview attributes.
Comment and name fixes to unit test
Fix for issue PHPOffice#526. Conditional operators in the selection parameter of COUNTIF functions were not being parsed properly, causing evaluations of formulae with such functions to sometimes fail. (Note: This is a recommit of this fix on a cleaner branch.)
Fix for issue PHPOffice#532. Properly set the selected cells for worksheets with frozen panes when writing Xlsx documents. Beforehand, the saved Xlsx documents were generating corruption warnings when opened in Excel.
|
It looks like I need to close and resubmit the pull request. I don't know why it included all these other merges and other commits. It is only a 3 line fix to one file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #532. Properly set the selected
cells for worksheets with frozen panes when writing Xlsx documents.
Beforehand, the saved Xlsx documents were generating corruption warnings
when opened in Excel.
This is:
Checklist:
Why this change is needed?
One gets corruption warnings from Excel when opening a saved Xlsx document
with a worksheet containing a frozen pane.