Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPOffice/PhpSpreadsheet#492 Allow CSV escape character to be set #510

Merged
merged 5 commits into from
May 23, 2018

Conversation

rdarcy1
Copy link
Contributor

@rdarcy1 rdarcy1 commented May 21, 2018

From issue #492.

This is:

- [x] a bugfix
- [ ] a new feature

Why this change is needed?

Allows the escape character of the CSV reader to be set, enabling the parsing of files that include the default escape character.

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a line in the changelog, following existing format, please ?

@PowerKiKi PowerKiKi merged commit c723833 into PHPOffice:develop May 23, 2018
@PowerKiKi
Copy link
Member

Thanks !

@rdarcy1
Copy link
Contributor Author

rdarcy1 commented May 23, 2018

No problem, thanks for merging :)

@rdarcy1 rdarcy1 deleted the csv-escape-character branch May 23, 2018 08:45
Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants