Escape any dollar signs when formatting cell data #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbaconjr
changed the title
sirbaconjr
force-pushed
the
fix-dollar-sign-issue-4242
branch
from
61c0f25 to
32a004f
Compare
8 tasks
oleibman
reviewed
Nov 25, 2024
oleibman
reviewed
Nov 25, 2024
sirbaconjr
force-pushed
the
fix-dollar-sign-issue-4242
branch
2 times, most recently
from
a726ff9 to
3af8f4e
Compare
oleibman
reviewed
Nov 25, 2024
sirbaconjr
force-pushed
the
fix-dollar-sign-issue-4242
branch
from
4d7bc6b to
171ca3a
Compare
This commit fix two issues that happened when the a cell was formatted as text * When the cell contains a number prefixed with dollar sign, this number is getting replaced with 0. The replacement happens due to the preg_replace function. * When the cell contains quotes, the quote would be removed.
sirbaconjr
force-pushed
the
fix-dollar-sign-issue-4242
branch
from
171ca3a to
3eee749
Compare
|
I finally figured it out - we want special processing for quote marks if they are part of the format, but not if they are part of the value. Updated your code slightly, added a new test case. I think this is what we need, or pretty close if not. I'll continue to think about for a day or two, and then merge. |
|
@sirbaconjr We seem to be working at cross purposes. If you have changes you still want to make, please use the current state of the PR as your starting point - commit 4b568b4 |
|
Thank you for your contribution, and for your patience as we expanded the scope of your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Fix #4242. When a cell is formatted as text and contains a number prefixed with dollar sign, this number is getting replaced with 0. The replacement happens due to the preg_replace function. This commit escapes any sollar signs on the cell data, so those are not replaced.