Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xlsx reader reading with read filter #421

Closed
wants to merge 3 commits into from
Closed

Fix xlsx reader reading with read filter #421

wants to merge 3 commits into from

Conversation

xklid101
Copy link
Contributor

Fix #370
Set rows and columns dimensions for only cells rows and columns allowed by readfilter

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Using readfilter with xlsx reader has no influence on rows or columns dimensions. So no matters if readfilter is used, all columns and rows are set by reader every time.

Fix #370
Set rows and columns dimensions for only cells rows and columns allowed by readfilter
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Would it be possible to create with_many_empty_cells.xlsx from code and thus avoid increasing the repository size ?

@xklid101
Copy link
Contributor Author

Check my latest commits, I've done some changes. If anything else to be done, let mi know and I'll try to do it. Or post some comments... Thx

@xklid101
Copy link
Contributor Author

Anything else to be done by me? Give me some comment please to let know if this PR is still alive. (The same for #420)
Thx.

@PowerKiKi
Copy link
Member

Thanks for your contributions

Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
…t all

Set rows and columns dimensions for only cells rows and columns
allowed by readfilter

Fixes PHPOffice#370
Closes PHPOffice#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants