Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topLeftCell #393

Closed
wants to merge 4 commits into from
Closed

fix topLeftCell #393

wants to merge 4 commits into from

Conversation

UziTech
Copy link
Contributor

@UziTech UziTech commented Feb 26, 2018

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Fixes a bug when calling ->freezePane("B2") without a second argument.

The selected cell will be B3 but should be B2

fixes #389

@UziTech
Copy link
Contributor Author

UziTech commented Feb 26, 2018

Another thing I noticed when writing the PR is that when ->freezePane('A1') is called the Excel doc will save without an error but will error when the Excel doc is opened.

Should there be a check for A1 in the freezePane function?

@PowerKiKi PowerKiKi closed this in bdc95b1 Mar 3, 2018
@PowerKiKi
Copy link
Member

Thanks, I merged it.

For the ->freezePane('A1'), I don't get any errors when opening with LibreOffice, so I would tend to do nothing.

Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
Fixes a bug when calling `$sheet->freezePane('B2')` without a second argument.
The selected cell will now be `B2` instead of the incorrect `B3`.

Fixes PHPOffice#389
Closes PHPOffice#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants