Fix issue with prepending zero in percentage -10<n<-9 #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasruunu
force-pushed
the
hotfix/prepending-zero-prc
branch
4 times, most recently
from
5173716 to
b8d58d3
Compare
nicholasruunu
force-pushed
the
hotfix/prepending-zero-prc
branch
2 times, most recently
from
0de3ed8 to
aa640bb
Compare
nicholasruunu
changed the title
nicholasruunu
force-pushed
the
hotfix/prepending-zero-prc
branch
from
aa640bb to
f4c4072
Compare
oleibman
requested changes
Feb 27, 2024
Before it was a bug when flooring negative numbers added to the length of the number for the sprintf mask. For example -0.091 becomes -9.1 in percentage, floors to -10 which is going to increase $wholePartSize by 1 and add a leading zero to the result: -09.1% with format 0.0%. This happened for negative ranges where floor will increse the length of the original number.
nicholasruunu
force-pushed
the
hotfix/prepending-zero-prc
branch
from
f4c4072 to
c1d141b
Compare
oleibman
approved these changes
Feb 27, 2024
|
Thank you for your contribution. |
No problem, thank you for the fast merge. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Before it was a bug when flooring negative numbers added to the length of the number for the sprintf mask.
For example -0.091 becomes -9.1 in percentage, floors to -10 which is going to increase
$wholePartSizeby 1 and add a leading zero to the result:-09.1%with format0.0%. This happened for the whole range-10<n<-9and I guess it would also happen for-100<n<-99etc.Fixes #3920