Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Padding When Determining Exact Column Width #3628

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Jul 1, 2023

Fix #3626. User felt that Exact setting of column width should not add padding. In order to avoid making this a breaking change, I am adding a new null|float|int property setPaddingAmountExact with setter and getter to Shared/Font; default is null (use current padding behavior).

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#3626. User felt that Exact setting of column width should not add padding. In order to avoid making this a breaking change, I am adding a new boolean property `usePaddingForExact` with setter and getter to Shared/Font; default is false (current behavior).
@oleibman oleibman changed the title Avoid Padding Determining Exact Column Width Avoid Padding When Determining Exact Column Width Jul 2, 2023
@oleibman oleibman marked this pull request as draft July 3, 2023 17:34
Instead of bool, make it null|float|int, allowing user to set whatever is deemed appropriate.
@oleibman oleibman marked this pull request as ready for review July 7, 2023 14:22
@oleibman oleibman merged commit 8fd727d into PHPOffice:master Jul 15, 2023
@oleibman oleibman deleted the issue3626 branch July 24, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The exact autosize does not work correctly
1 participant