fix unescaped slash error in preg match

[SaidkhojaIftikhor]

This is:

• a bugfix
• a new feature
• refactoring
• additional unit tests

Checklist:

• Changes are covered by unit tests
  • Changes are covered by existing unit tests
  • New unit tests have been added
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
• Documentation is updated as necessary

Why this change is needed?

I faced with an error WARNING preg_match(): Unknown modifier '�'.
After some debuging I found out that preg_quote doesn't escape slash character. I added slash character as a second parameter of preg_quote and now it works :)

preg_quote

example code: This code will throw an error because $columnName has a slash in it and preg_quote will not escape it

$columnName = 'Buy/Sell';
$columnId = 'C';
$reference = '[B5]';

$cellReference = $columnId . 5;
$pattern1 = '/\[' . preg_quote($columnName) . '\]/miu';
$pattern2 = '/@' . preg_quote($columnName) . '/miu';

if (preg_match($pattern1, $reference) === 1) {
    $reference = preg_replace($pattern1, $cellReference, $reference);
} elseif (preg_match($pattern2, $reference) === 1) {
    $reference = preg_replace($pattern2, $cellReference, $reference);
}

[MarkBaker]

The crux of the PR; and I've verified that the change is necessary her.
Can you provide a unit test that will demonstrate the issue, and prove that this fix works?

[SaidkhojaIftikhor]

Ok, I will try. I am new to this repository and I don't understand a lot of things, that's why I added delimiter everywhere in code.

How can I learn the codebase ? I tried to read the code but it's kinda hard

[MarkBaker]

As with the Structured Reference changes, can you provide unit tests to verify that this is a problem, and that the solution does resolve that problem for all these instances where you've made the change?

[oleibman]

I looked into the testing that would be needed, and it seems pretty complicated, so complicated that I have just submitted 3 different PRs to handle it. If those PRs are merged, I will close this one.

[oleibman]

The replacement PRs are merged. Closing this one.