Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of the Value Binder when setting a Cell value #3361

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Allow override of the Value Binder when setting a Cell value #3361

merged 1 commit into from
Feb 14, 2023

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Feb 13, 2023 •
edited
Loading

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Allow override of the Value Binder when setting a Cell value

@MarkBaker MarkBaker force-pushed the Cell-SetValue-Binder-Override branch 2 times, most recently from 83d8838 to f9df861 Compare February 14, 2023 09:02
@MarkBaker MarkBaker force-pushed the Cell-SetValue-Binder-Override branch from f9df861 to b40e131 Compare February 14, 2023 09:13
@MarkBaker MarkBaker marked this pull request as ready for review February 14, 2023 09:20
@MarkBaker MarkBaker merged commit 5405eaf into master Feb 14, 2023
@MarkBaker MarkBaker deleted the Cell-SetValue-Binder-Override branch February 23, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker