Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "chained" range operators in the Calculation Engine #2746

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

MarkBaker
Copy link
Member

This is:

- [X] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Reference Issue #2730

Support for "chained" range operators in the Calculation Engine (e.g. A…3:B1:C2 which gives an effective combined range of A1:C3 or A5:C10:C20:F1 which gives an effective combined range of A1:F20).

Next step will be allowing Named Cells/Ranges to be chained in the same way.

…A3:B1:C2` which gives an effective combined range of `A1:C3` or `A5:C10:C20:F1` which gives an effective combined range of `A1:F20`).

Next step will be allowing Named Cells/Ranges to be chained in the same way.
@MarkBaker MarkBaker marked this pull request as draft April 13, 2022 10:41
It gets awkward when the defined name is for an actual range rather than for an individual named cell; because we need to manipulate the stack when that happens.

The code is ugly, and this is a rather simplistic approach, but it works as long as the named range is a cell, a cell range, or even a "chained" range - it won't work if we have union or intersection operators in the defined range - but it does provide formula support that never existed before.
@MarkBaker MarkBaker marked this pull request as ready for review April 13, 2022 15:58
@MarkBaker MarkBaker merged commit d4585ed into master Apr 13, 2022
@MarkBaker MarkBaker deleted the Issue-2730_Combined-Ranges branch April 13, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant