-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to use customized pdf library #266
Closed
SailorMax
wants to merge
5
commits into
PHPOffice:develop
from
SailorMax:allow_to_use_customized_pdf_libraries
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a0e20ee
allow to use customized pdf library
SailorMax f2ce202
rename method, comment fixes, doc sample
SailorMax 438d845
string in changelog
SailorMax a4f1afc
Merge branch 'develop' into allow_to_use_customized_pdf_libraries
SailorMax 310babd
Merge branch 'develop' into allow_to_use_customized_pdf_libraries
SailorMax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,18 @@ | |
|
||
class Dompdf extends Pdf implements IWriter | ||
{ | ||
/** | ||
* Gets the implementation of external PDF library that should be used. | ||
* | ||
* @param array $config Configuration array | ||
* | ||
* @return Dompdf implementation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be |
||
*/ | ||
protected function getExternalWriter() | ||
{ | ||
return new \Dompdf\Dompdf(); | ||
} | ||
|
||
/** | ||
* Save Spreadsheet to file. | ||
* | ||
|
@@ -51,7 +63,7 @@ public function save($pFilename) | |
} | ||
|
||
// Create PDF | ||
$pdf = new \Dompdf\Dompdf(); | ||
$pdf = $this->getExternalWriter(); | ||
$pdf->setPaper(strtolower($paperSize), $orientation); | ||
|
||
$pdf->loadHtml( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,18 @@ | |
|
||
class Mpdf extends Pdf implements IWriter | ||
{ | ||
/** | ||
* Gets the implementation of external PDF library that should be used. | ||
* | ||
* @param array $config Configuration array | ||
* | ||
* @return Mpdf implementation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be |
||
*/ | ||
protected function getExternalWriter($config) | ||
{ | ||
return new \Mpdf\Mpdf($config); | ||
} | ||
|
||
/** | ||
* Save Spreadsheet to file. | ||
* | ||
|
@@ -55,7 +67,7 @@ public function save($pFilename) | |
|
||
// Create PDF | ||
$config = ['tempDir' => $this->tempDir]; | ||
$pdf = new \Mpdf\Mpdf($config); | ||
$pdf = $this->getExternalWriter($config); | ||
$ortmp = $orientation; | ||
$pdf->_setPageSize(strtoupper($paperSize), $ortmp); | ||
$pdf->DefOrientation = $orientation; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no parameter named $config.