Fix saving XLSX with drawings (#1462) #2462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I don’t know how to push the code to v1.8.x, I know I shouldn’t request to master (has confliects) |
|
Converting to draft for now. It will not be merged, but I am not closing it just yet. If you must work on a no-longer-supported version of PHP, and there are many reasons why shouldn't, the best that I can suggest is using Composer to download the version you want, and then manually apply the changes you need. |
|
ok,thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
This commit has been merged into version 1.13.0, I hope to merge into version 1.8.x at the same time, so as to be able to support php7.0
Fix #2461, sort of.