Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed null conversation for strToUpper #2292

Merged
merged 3 commits into from
Nov 1, 2021
Merged

fixed null conversation for strToUpper #2292

merged 3 commits into from
Nov 1, 2021

Conversation

brainfoolong
Copy link
Contributor

fixed in the same way as it already has been done for strToLower

This is:

- [x] a bugfix

Checklist:

Why this change is needed?

Just a fix applied to strToUpper in the same way as it has already been done for strToLower.

fixed in the same way as it already has been done for strToLower
@oleibman
Copy link
Collaborator

oleibman commented Sep 9, 2021

Might you be able to add a formal test which fails with the existing code but succeeds with your change?

@brainfoolong
Copy link
Contributor Author

Unfortunetely i don't have an example. The error happens for me, when i load an existing excel file (that was creating by unknown software) that i can't publish here. I was unable to reproduce it in a way that i can post here. As soon as i manipulate the excel and re-save it without sensible information, the error is gone.

I tried, but without success. Also i don't had time to invest more time.

Sorry.

@PowerKiKi PowerKiKi merged commit 4c4ae26 into PHPOffice:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants