-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added xml reader hyperlink support #223
Closed
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3a6f7ed
Added xml reader hyperlink support
yasar-luo 8f8bbba
Support for read Hyperlink for xml
yasar-luo dd5c859
Resolve conflict
yasar-luo e1ad90c
Revert "Resolve conflict"
yasar-luo baf0cf3
Revert "Support for read Hyperlink for xml"
yasar-luo a553c64
Recommit
yasar-luo c78437a
Recommit
yasar-luo bad1b33
Fix code style and update the features cross reference.md
yasar-luo 0fefd21
Update features-cross-reference.md
PowerKiKi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,11 +2,34 @@ | |
|
||
namespace PhpOffice\PhpSpreadsheetTests\Reader; | ||
|
||
use PhpOffice\PhpSpreadsheet\Cell\DataType; | ||
use PhpOffice\PhpSpreadsheet\Reader\BaseReader; | ||
use PhpOffice\PhpSpreadsheet\Spreadsheet; | ||
use PHPUnit_Framework_TestCase; | ||
|
||
class XEEValidatorTest extends PHPUnit_Framework_TestCase | ||
{ | ||
/** | ||
* @var Spreadsheet | ||
*/ | ||
private $spreadsheetXEETest; | ||
|
||
/** | ||
* @return Spreadsheet | ||
*/ | ||
protected function loadXEETestFile() | ||
{ | ||
if (!$this->spreadsheetXEETest) { | ||
$filename = __DIR__ . '/../../../samples/templates/Excel2003XMLTest.xml'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because we $filename = '../samples/templates/Excel2003XMLTest.xml'; |
||
|
||
// Load into this instance | ||
$reader = new Xml(); | ||
$this->spreadsheetXEETest = $reader->loadIntoExisting($filename, new Spreadsheet()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not just |
||
} | ||
|
||
return $this->spreadsheetXEETest; | ||
} | ||
|
||
/** | ||
* @dataProvider providerInvalidXML | ||
* @expectedException \PhpOffice\PhpSpreadsheet\Reader\Exception | ||
|
@@ -53,4 +76,19 @@ public function providerValidXML() | |
|
||
return $tests; | ||
} | ||
|
||
/** | ||
* Check if it can read XML Hyperlink correctly. | ||
*/ | ||
public function testReadHyperlinks() | ||
{ | ||
$spreadsheet = $this->loadXEETestFile(); | ||
$firstSheet = $spreadsheet->getSheet(0); | ||
|
||
$hyperlink = $firstSheet->getCell('L1'); | ||
|
||
$this->assertEquals(DataType::TYPE_STRING, $hyperlink->getDataType()); | ||
$this->assertEquals('PHPExcel', $hyperlink->getValue()); | ||
$this->assertEquals('http://www.phpexcel.net/', $hyperlink->getHyperlink()->getUrl()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use "PHPExel" anymore, but instead "http://www.example.com" and "My website" or something similar.