New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the BIFF-8 Xls colour mappings in the Reader #2156

Merged

MarkBaker merged 2 commits into master from Xls-Colour-Mappings

Jun 13, 2021

Member

MarkBaker commented Jun 12, 2021 •

edited

Loading

This is:

- [X] a bugfix
- [ ] a new feature

Checklist:

Changes are covered by unit tests
Code style is respected
Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
CHANGELOG.md contains a short summary of the change
Documentation is updated as necessary

Why this change is needed?

Resolve BIFF-8 colour map for the Xls reader. This should fix Issue #2147

MarkBaker added 2 commits

June 12, 2021 15:08


          Fix for the BIFF-8 Xls colour mappings in the Reader

f8f1d27


          Unit test for reading colours, writing hen rereading and ensuring tha…

716124c

…t the RGB values have not changed

MarkBaker merged commit 74b02fb into master

MarkBaker deleted the Xls-Colour-Mappings branch

July 2, 2021 09:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet