fix: Set font size to 10 when given 0

[drola]

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

• Changes are covered by unit tests
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change
• Documentation is updated as necessary

Why this change is needed?

This change restored behavior from PHP7 in PHP8. In PHP7 calling
setSize(0) resulted in font size being set to 10. The fix addresses
change to equal comparisons in PHP8. Extra comparison is added to keep
result from PHP7 in PHP8 for the setSize(0) case.

[MarkBaker]

Thank you for the contribution; although any fix to the values passed to the method should include other invalid values as well

[drola]

Thank you for the review.

I expanded the test and added the handling of all other invalid values.

[MarkBaker]

Thanks for making those changes to full validate the value, and for ensuring that it's covered by unit tests...

When we first wrote those basic setters, we never really expected any developer to pass through invalid values, so the validation checks were minimal.... over the years, we've been proven wrong time and again, but never really got round to improving the validation checks, as there were always more important demands for more serious bugs or new features

[MarkBaker]

The docblock needs modifying to mixed to keep phpstan happy, and it looks like phpcs is complaining about trailing white space in the comment lines.
If you can just make those changes, then the PR is good to merge

[MarkBaker]

The docblock needs modifying to mixed to keep phpstan happy, and it looks like phpcs is complaining about trailing white space in the comment lines.
If you can just make those changes, then the PR is good to merge

[drola]

Thank you. Updated the docblock, ran composer fix, composer check and rebased on top of master.