Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathTrig - Change Names of funcWhatever to evaluate #2008

Merged
merged 4 commits into from
Apr 20, 2021
Merged

MathTrig - Change Names of funcWhatever to evaluate #2008

merged 4 commits into from
Apr 20, 2021

Conversation

oleibman
Copy link
Collaborator

Per discussions while MathTrig was being broken up, this would help standardize the code. That idea was adopted partway through the breakup. This PR applies that standardization to the earlier efforts. A similar effort is required for DateTime; that will come later. This PR replaces #2006.

The only 2 remaining funcWhatevers in MathTrig are both in SUM, which required two different methods depending on whether or not string parameters were to be ignored. It seems appropriate to leave those method names non-standardized in order to require a decision about which is to be used if they are invoked internally.

3 Phpstan grandfathered errors were eliminated as part of this change, and its baseline has changed accordingly.

This is:

- [ ] a bugfix
- [ ] a new feature
- [x] refactoring

Checklist:

Why this change is needed?

Per discussions while MathTrig was being broken up, this would help standardize the code. That idea was adopted partway through the breakup. This PR applies that standardization to the earlier efforts. A similar effort is required for DateTime; that will come later. This PR replaces #2006.

The only 2 remaining funcWhatevers in MathTrig are both in SUM, which required two different methods depending on whether or not string parameters were to be ignored. It seems appropriate to leave those method names non-standardized in order to require a decision about which is to be used if they are invoked internally.

3 Phpstan grandfathered errors were eliminated as part of this change, and its baseline has changed accordingly.
@oleibman
Copy link
Collaborator Author

@MarkBaker and @PowerKiKi - this change seems a little snakebit. Scrutinizer fails because it received a segfault in phpcs? Even though Github phpcs runs fine? Seems inconceivable that my change has anything to do with the Scrutinizer problem, but, whether or not that's true, I have no idea how to move forward.

Add comment to see if this gets Scrutinizer past its segfault. Seems doubtful, but can't hurt to try.
@oleibman
Copy link
Collaborator Author

Yay! Changing a comment forced Scrutinizer (and the other tests) to run again, and this time it didn't segfault. So the change is ready.

@MarkBaker MarkBaker merged commit b05dc31 into PHPOffice:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants