Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Binomial Distribution functions from Statistical #1974

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

MarkBaker
Copy link
Member

This is:

- [ ] a bugfix
- [ ] a new feature
- [X] refactoring

Checklist:

Why this change is needed?

Replace the old MS algorithm for CRITBINOM() (which has now been replaced with te BINOM.INV() function) with a brute force approach - I'll look to refine it later. The MS algorithm is no longer documented, and the implementation produced erroneous results anyway.

TODO - Use a bisection to identify an appropriate start point before brute force.... easier to do when we have a known range between 0 and $trials

Sorry, something went wrong.

MarkBaker added 3 commits March 30, 2021 21:14
Replace the old MS algorithm for CRITBINOM() (which has now been replaced with te BINOM.INV() function) with a brute force approach - I'll look to refine it later. The MS algorithm is no longer documented, and the implementation produced erroneous results anyway
…ative flag to support the additional argument for the newer NEGBINOM.DIST() function
@MarkBaker MarkBaker merged commit 029f345 into master Mar 30, 2021
@MarkBaker MarkBaker deleted the Statistical-Functions-Binomial-Distribution branch March 30, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant