Initial experiments using the new Database query logic with Conditional Statistical Functions #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 23, 2021 22:20
…al Statistical functions (e.g. COUNTIF(), AVERAGEIF(), COUNTIFS(), etc)
…IFS(), AVERAGEIFS(), etc
…IFS(), AVERAGEIFS(), etc
|
Down to just 2 failing tests; and those are related to how MS Excel handles counting values, and the differences between literals and values from cells... MS! Why do you make things so inconsistent? |
added 11 commits
February 26, 2021 13:49
Some refactoring will help with building the database/condition sets in a cleaner manner; and need to add a more comprehensive set of unit tests to cover more variations and edge cases
…n set and database for AVERAGEIFS(), MAXIFS() and MINIFS() This should be further rationalised for memory improvement by avoiding any modification to the args
…s for edge cases... but feeling very satisfied that this is a majr improvement to code quality, and that it adds major additional support for booleans, dates, percentages, and wild-carded strings to Database functions and Conditional functions
…ll protecting our * and ? wildcard characters
MarkBaker
deleted the
Statistical-Functions-Experiments-with-Conditional-Functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial experiments using the new Database query logic with Conditional Statistical functions (e.g. COUNTIF(), AVERAGEIF(), COUNTIFS(), etc)
This is:
Checklist:
Why this change is needed?
Using the new Database function query logic to support all relevant forms of queries in the Conditional Statistical functions, including support for boolean datatypes, wildcard text, etc
Also using this to refactor the Conditional functions outside of the main Statistical class, and into a dedicated class as part of the big refactoring of all Excel function implementations