Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract all Error functions from the Engineering class into a dedicated Erf and ErfC classes #1850

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

MarkBaker
Copy link
Member

Extract all Error functions from the Engineering class into a dedicated Erf and ErfC classes

Retain the original methods in the Engineering class as stubs for BC, but deprecate them. They will be removed for PHPSpreadsheet v2

Note that unit tests still point to the Engineering class stubs; these should be modified to use the Erf and ErfC classes directly when the stubs are removed

This is:

- [ ] a bugfix
- [ ] a new feature
- [ ] code restructuring and refactoring

Checklist:

Why this change is needed?

This is a refactoring to reduce complexity of the Excel function classes in PHPSpreadsheet, making them easier to maintain in the future

MarkBaker added 2 commits February 13, 2021 12:20
…ed Erf and ErfC classes

Retain the original methods in the Engineering class as stubs for BC, but deprecate them. They will be removed for PHPSpreadsheet v2

Note that unit tests still point to the Engineering class stubs; these should be modified to use the Erf and ErfC classes directly when the stubs are removed
@MarkBaker MarkBaker merged commit be328c3 into master Feb 13, 2021
@MarkBaker MarkBaker deleted the Engineering-Move-Erf-Functions-to-dedicated-class branch February 13, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant