Final stage of preparation for PHP8 #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments and returns) and that all argument names for public methods are meaningful (in readiness for PHP8 named arguments)
added 28 commits
October 30, 2020 11:15
# Conflicts: # src/PhpSpreadsheet/Style/Alignment.php # src/PhpSpreadsheet/Style/Color.php
added 13 commits
November 11, 2020 15:41
# Conflicts: # CHANGELOG.md # src/PhpSpreadsheet/Shared/Drawing.php # src/PhpSpreadsheet/Spreadsheet.php # src/PhpSpreadsheet/Style/Conditional.php
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
PowerKiKi
force-pushed
the
PHP8-Sane-Property-Names
branch
from
d3f7ebf to
59c706e
Compare
|
I "finished" this PR by fixing CI and merging it, because it was already super old, and it would only get harder to merge it if we waited longer. But there are still parameters with non-optimal names that could be fixed in future PR |
This was referenced Nov 1, 2021
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Nov 3, 2021
Fix issue PHPOffice#2368. PR PHPOffice#2265 moved the place where data validations were written to the worksheet. PR PHPOffice#1694 was installed afterwards, and accidentally restored the original location, so validations are now being written twice.
5 tasks
oleibman
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work on ensuring that all methods are properly type-hinted (arguments and returns) and that all argument names for public methods are meaningful (in readiness for PHP8 named arguments)
This is:
Checklist:
Why this change is needed?
Final stage of preparation for PHP8