-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mPDF to version 7.0. #149
Conversation
I didn't realize it was only in beta. I am not so sure anymore whether this should be merged since support for unreleased software might bring up issue... Any idea about the speed of development of mPDF and when a stable might be released ? |
Here is 7.0 release milestone: https://github.com/mpdf/mpdf/milestone/2 |
Mpdf 6.1 is fully not compabitable with php 7.1. |
As soon as it is released, yes. But I don't think it fair to force PhpSpreadsheet users to use an unreleased version of Mpdf meanwhile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config required
@@ -73,7 +73,7 @@ public function save($pFilename) | |||
} | |||
|
|||
// Create PDF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't work without this config.
$config = ['tempDir' => $this->getTempDir()];
$pdf = new \Mpdf\Mpdf($config);
Release Candidate version of mPDF 7.0 was tagged - https://github.com/mpdf/mpdf/releases/tag/v7.0.0-RC1 |
Closed via 360db8d, thanks for keeping me up to date. |
Fix for issue #144.
Stability of mPDF package is reduced to 'dev' because there is no stable release of version 7.0 yet.