Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mPDF to version 7.0. #149

Closed
wants to merge 1 commit into from

Conversation

KacerCZ
Copy link
Contributor

@KacerCZ KacerCZ commented May 1, 2017

Fix for issue #144.

Stability of mPDF package is reduced to 'dev' because there is no stable release of version 7.0 yet.

@KacerCZ KacerCZ mentioned this pull request May 1, 2017
@PowerKiKi
Copy link
Member

PowerKiKi commented May 1, 2017

I didn't realize it was only in beta. I am not so sure anymore whether this should be merged since support for unreleased software might bring up issue...

Any idea about the speed of development of mPDF and when a stable might be released ?

@b1rdex
Copy link

b1rdex commented May 11, 2017

Here is 7.0 release milestone: https://github.com/mpdf/mpdf/milestone/2

@titanrat
Copy link
Contributor

Mpdf 6.1 is fully not compabitable with php 7.1.
I think this is a problem and it's better to upgrade to Mpdf 7 faster.

@PowerKiKi
Copy link
Member

As soon as it is released, yes. But I don't think it fair to force PhpSpreadsheet users to use an unreleased version of Mpdf meanwhile

Copy link
Contributor

@titanrat titanrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config required

@@ -73,7 +73,7 @@ public function save($pFilename)
}

// Create PDF
Copy link
Contributor

@titanrat titanrat May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work without this config.
$config = ['tempDir' => $this->getTempDir()];
$pdf = new \Mpdf\Mpdf($config);

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Sep 27, 2017

Release Candidate version of mPDF 7.0 was tagged - https://github.com/mpdf/mpdf/releases/tag/v7.0.0-RC1

@PowerKiKi
Copy link
Member

Closed via 360db8d, thanks for keeping me up to date.

@PowerKiKi PowerKiKi closed this Sep 29, 2017
@KacerCZ KacerCZ deleted the issue144-mpdf7 branch October 13, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants