MATCH function fix #1122
Merged
MATCH function fix #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cast only strings to lower cased values - fix gives up immediately if the current element is smaller than the searched value ( match_type=-1) - fix 0 == false & 1 == true - add test cases - update changelog
…match-fix # Conflicts: # CHANGELOG.md
|
@MarkBaker can you please check this PR? If there is anything let me know. |
|
@PowerKiKi maybe you can take a look at this PR? |
|
Thanks for this great PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATCH function is buggy, this PR fixes MATCH function implementation so that it works as expected. Bugs initially were reported as issue: #1116
This is:
Checklist:
Why this change is needed?
@see Error report #1116