Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Xlsx Properties Reader code into a separate class #1001

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Refactor Xlsx Properties Reader code into a separate class #1001

merged 5 commits into from
Jun 10, 2019

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Jun 9, 2019 •
edited
Loading

This is:

- [ ] a bugfix
- [ ] a new feature
- [x] refactoring

Checklist:

Why this change is needed?

@MarkBaker MarkBaker merged commit 6c25b6f into master Jun 10, 2019
@MarkBaker MarkBaker deleted the Refactor-Xlsx-Writer branch June 10, 2019 14:58
guillaume-ro-fr pushed a commit to guillaume-ro-fr/PhpSpreadsheet that referenced this pull request Jun 12, 2019
@guillaume-ro-fr
Refactor Xlsx Properties Reader code into a separate class (PHPOffice…
9bbb8dc 
…#1001)

* Unit tests for refactoring Spreadsheet properties
* Refactor Xlsx Properties Reader code into a separate class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker