When writing CSV file thousand separator and decimal separator are not respected

[sakarikl]

This is:

• a bug report
• a feature request
• not a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

CSV to have numbers set as is defined in decimal separator and thousand separator

What is the current behavior?

if thousand separator is not ',' or decimal separator is not '.' they are hard coded.

    protected static function adjustSeparators(string $value): string
    {
        $thousandsSeparator = StringHelper::getThousandsSeparator();
        $decimalSeparator = StringHelper::getDecimalSeparator();

        if ($thousandsSeparator !== ',' || $decimalSeparator !== '.') {
            $value = str_replace(['.', ',', "\u{fffd}"], ["\u{fffd}", '.', ','], $value);
        }

        return $value;
    }

https://github.com/PHPOffice/PhpSpreadsheet/blob/master/src/PhpSpreadsheet/Style/NumberFormat/BaseFormatter.php

What are the steps to reproduce?

<?php

require __DIR__ . '/vendor/autoload.php';

\PhpOffice\PhpSpreadsheet\Shared\StringHelper::setDecimalSeparator('.');
\PhpOffice\PhpSpreadsheet\Shared\StringHelper::setThousandsSeparator('');

$spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();
$sheet = $spreadsheet->getActiveSheet();
$sheet->setCellValue('A1', 1.4);
$sheet->setCellValue('B1', 1004.5);
$sheet->setCellValue('C1', 1000000.5);

\ob_start();
$ioWriter = \PhpOffice\PhpSpreadsheet\IOFactory::createWriter($spreadsheet, \PhpOffice\PhpSpreadsheet\IOFactory::WRITER_CSV);
$ioWriter->setDelimiter(';');
$ioWriter->save('php://output');
$output = \ob_get_clean();

echo $output;

Output

"1,4";"1004,5";"1000000,5"

Expected output

"1.4";"1004.5";"1000000.5"

If this is an issue with reading a specific spreadsheet file, then it may be appropriate to provide a sample file that demonstrates the problem; but please keep it as small as possible, and sanitize any confidential information before uploading.

What features do you think are causing the issue

• Reader
• Writer
• Styles
• Data Validations
• Formula Calculations
• Charts
• AutoFilter
• Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

At least CSV

Which versions of PhpSpreadsheet and PHP are affected?

2.0.0

[sakarikl]

Will fix reproduce code in a moment :)

edit. And now fixed