You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- [x] a bug report
- [ ] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)
What is the expected behavior?
I expect IOFactory::load($filename) to take a reasonable amount of time compared to IOFactory::load($filename, IReader::READ_DATA_ONLY).
What is the current behavior?
We have a file that starting from #3497 (1.29.0) takes up to 5x longer to load without IReader::READ_DATA_ONLY compared to not specifying any flags.
FixPHPOffice#3683. PR PHPOffice#3497 fixed a problem involving formulas and the quotePrefix style attribute. It did so by automatically turning off quotePrefix for any formulas encountered by Xlsx Reader. Under the right circumstances, it turns out that that change can cause a file read to take noticeably more time than previously. This change will turn off quotePrefix only if it is already on, and that appears to eliminate the performance problem while continuing to solve the original problem.
* Performance Improvement for Xlsx Reader
Fix#3683. PR #3497 fixed a problem involving formulas and the quotePrefix style attribute. It did so by automatically turning off quotePrefix for any formulas encountered by Xlsx Reader. Under the right circumstances, it turns out that that change can cause a file read to take noticeably more time than previously. This change will turn off quotePrefix only if it is already on, and that appears to eliminate the performance problem while continuing to solve the original problem.
* Very Minor Improvement
* Update CHANGELOG.md
This is:
What is the expected behavior?
I expect
IOFactory::load($filename)
to take a reasonable amount of time compared toIOFactory::load($filename, IReader::READ_DATA_ONLY)
.What is the current behavior?
We have a file that starting from #3497 (1.29.0) takes up to 5x longer to load without
IReader::READ_DATA_ONLY
compared to not specifying any flags.What are the steps to reproduce?
Put this file in the PHP directory: Reproducer.xlsx
Comment out
PhpSpreadsheet/src/PhpSpreadsheet/Style/Style.php
Line 685 in b879cdd
What features do you think are causing the issue
Does an issue affect all spreadsheet file formats? If not, which formats are affected?
.xlsx
Which versions of PhpSpreadsheet and PHP are affected?
PhpSpreadsheet 1.29.0
This has been tested on PHP 8.1.22 and PHP 8.2.9
The text was updated successfully, but these errors were encountered: