Xls Writer Cannot Parse TRUE When Supplied as a Function Argument

[oleibman]

This is:

- [x] a bug report
- [ ] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

A function argument of TRUE (and presumably FALSE) can be parsed by the Xls Writer so that the formula is reproduced faithfully when the spreadsheet is saved as Xls.

What is the current behavior?

Parser throws an Exception at the end of function fact. The writer still writes the cell, but with its calculated value rather than its formula. I can see that another regexp or two needs to be tested for this, but I have not yet figured out what should happen if the new regexes are matched. Note that TRUE is parsed correctly as just a cell value (cell A1), and that the TRUE() function is parsed correctly when supplied as an argument (cell A4). However, both cells A2 (TRUE is first argument) and A3 (TRUE is last argument) are written out as a value rather than a formula.

What are the steps to reproduce?

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

<?php

require __DIR__ . '/vendor/autoload.php';

use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xls;

$spreadsheet = new Spreadsheet();
$sheet = $spreadsheet->getActiveSheet();
$sheet->getCell('A1')->setValue(true);
$sheet->getCell('A2')->setValue('=AND(TRUE)');
$sheet->getCell('A3')->setValue('=AND(TRUE, 0)');
$sheet->getCell('A4')->setValue('=AND(TRUE())');
$writer = new Xls($spreadsheet);
$outfile = 'formulaerr2.xls';
$writer->save($outfile);
echo "Saved $outfile\n";

If this is an issue with reading a specific spreadsheet file, then it may be appropriate to provide a sample file that demonstrates the problem; but please keep it as small as possible, and sanitize any confidential information before uploading.

What features do you think are causing the issue

• Reader
• Writer, in particular Writer/Xls/Parser
• Styles
• Data Validations
• Formula Calculations
• Charts
• AutoFilter
• Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

Only Xls is affected.

Which versions of PhpSpreadsheet and PHP are affected?

All.