Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 breaks DateTime tests #311

Closed
criztovyl opened this issue Jan 1, 2018 · 0 comments
Closed

2018 breaks DateTime tests #311

criztovyl opened this issue Jan 1, 2018 · 0 comments

Comments

@criztovyl
Copy link
Contributor

This is:

- [x] a bug report
- [ ] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

DateTime-Tests pass.

What is the current behavior?

DatTime-Tests fail because the test values are for 2017 (?).

// 01/01 of the current year
[
42736,
'1 Jan',
],
// 31/12 of the current year
[
43100,
'31/12',
],
// Excel reads as 1st December 1931, not 31st December in current year
[
11658,
'12/31',
],
// 05/07 of the current year
[
42921,
'5-JUL',
],
// 05/07 of the current year
[
42921,
'5 Jul',
],

What are the steps to reproduce?

git clone https://github.com/PHPOffice/PhpSpreadsheet.git
cd PhpSpreadsheet
composer install
./vendor/bin/phpunit

Which versions of PhpSpreadsheet and PHP are affected?

No released version is affected, it's just a failing test.

Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this issue Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant