Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pictures to comments #1547

Closed
Mymko opened this issue Jun 25, 2020 · 5 comments
Closed

Add Pictures to comments #1547

Mymko opened this issue Jun 25, 2020 · 5 comments
Labels
enhancement images Images

Comments

@Mymko
Copy link

Mymko commented Jun 25, 2020 •
edited
Loading

This is:

- [ * ] a feature request

Need a function to add pictures to the comment.

In Excel, it is added:
Format Comment -> Colors and Lines -> Fill -> Fill Effects -> Picture -> Select Picture

image

image

This implementation speeds up the rendering of the book if there are many pictures in the document.
@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Sep 13, 2020
@Mymko
Copy link
Author

Mymko commented Sep 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

What?

@stale stale bot removed the stale label Sep 15, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@Mymko
Copy link
Author

Mymko commented Dec 28, 2020

up

@stale stale bot removed the stale label Dec 28, 2020
@Mymko Mymko mentioned this issue Mar 10, 2021
Closed
@oleibman oleibman mentioned this issue Dec 3, 2021
Merged
6 tasks
leo-bsv pushed a commit to leo-bsv/PhpSpreadsheet that referenced this issue Dec 4, 2021
XLSX-Image-Background-In-Comments (PHPOffice#1547)
63aed78
leo-bsv pushed a commit to leo-bsv/PhpSpreadsheet that referenced this issue Dec 4, 2021
XLSX-Image-Background-In-Comments (PHPOffice#1547)
d90d319
oleibman pushed a commit that referenced this issue Dec 17, 2021
@leo-bsv
Xlsx image background in comments #1547 (#2422)
a7f687f 
* XLSX Image background in comments

* XLSX-Image-Background-In-Comments (#1547)

* Test fixes, convertion for comment sizes from px to pt, fix for setting image sizes from zip, set image type

* Merge remote-tracking branch 'origin/XLSX-Image-Background-In-Comments' into XLSX-Image-Background-In-Comments

* Tests to check reloaded document.

Co-authored-by: Burkov Sergey
@oleibman
Copy link
Collaborator

Addressed by merge of PR 2422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement images Images
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarkBaker @oleibman @Mymko