Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFormattedValue: invalid custom format value #1079

Closed
Blacknife opened this issue Jul 14, 2019 · 4 comments
Closed

getFormattedValue: invalid custom format value #1079

Blacknife opened this issue Jul 14, 2019 · 4 comments

Comments

@Blacknife
Copy link
Contributor

Blacknife commented Jul 14, 2019

This is:

- [x] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

Formatted value in accordance with the format 000\.00\.000\.0

Example: if value 11020011 and format code 000\.00\.000\.0 i wait formatted value 011.02.001.1

What is the current behavior?

Excel:
value 2010035
format 000\.00\.000\.0
dispay 002.01.003.5

PhpSpreadscheet:
value 2010035
format code 000\\.00\\.000\\.0
formatted value 2010035.00.2010035.00

What are the steps to reproduce?

Example Excel file https://drive.google.com/file/d/1P_3K_x-pL_GlW7xxBxZC3qgcYCFirzKr/view?usp=sharing

There is only one cell in the file with data 2010035 and format 000\.00\.000\.0

<?php

require __DIR__ . '/vendor/autoload.php';

$reader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();
$spreadsheet = $reader->load($pFilename)->getActiveSheet();

echo $spreadsheet->getCellByColumnAndRow(1, 1)->getValue();
// 2010035

echo $spreadsheet->getCellByColumnAndRow(1, 1)->getStyle()->getNumberFormat()->getFormatCode();
// 000\\.00\\.000\\.0

echo $spreadsheet->getCellByColumnAndRow(1, 1)->getFormattedValue();
// 2010035.00.2010035.00

Which versions of PhpSpreadsheet and PHP are affected?

PHP 7.1
PhpSpreadscheet 1.6.0, 1.7.0, 1.8.2

@MarkBaker
Copy link
Member

The problem is the . character; the code is only testing for the presence of a . without looking to see if it's escaped... it'll take me a while to modify the block of code that handles "special" formatting masks

@MarkBaker
Copy link
Member

resolved in master branch

@MarkBaker
Copy link
Member

resolved in master

@Blacknife
Copy link
Contributor Author

@MarkBaker thanks! I checked on the master branch - it works as expected!

PowerKiKi added a commit that referenced this issue Aug 17, 2019
1.9.0

### Added

- When &lt;br&gt; appears in a table cell, set the cell to wrap [#1071](#1071) and [#1070](#1070)
- Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF [#1056](#1056)
- HLookup needs an ordered list even if range_lookup is set to false [#1055](#1055) and [#1076](#1076)
- Improve performance of IF function calls via ranch pruning to avoid resolution of every branches [#844](#844)
- MATCH function supports `*?~` Excel functionality, when match_type=0 [#1116](#1116)
- Allow HTML Reader to accept HTML as a string [#1136](#1136)

### Fixed

- Fix to AVERAGEIF() function when called with a third argument
- Eliminate duplicate fill none style entries [#1066](#1066)
- Fix number format masks containing literal (non-decimal point) dots [#1079](#1079)
- Fix number format masks containing named colours that were being misinterpreted as date formats; and add support for masks that fully replace the value with a full text string [#1009](#1009)
- Stricter-typed comparison testing in COUNTIF() and COUNTIFS() evaluation [#1046](#1046)
- COUPNUM should not return zero when settlement is in the last period [#1020](#1020) and [#1021](#1021)
- Fix handling of named ranges referencing sheets with spaces or "!" in their title
- Cover `getSheetByName()` with tests for name with quote and spaces [#739](#739)
- Best effort to support invalid colspan values in HTML reader - [#878](#878)
- Fixes incorrect rows deletion [#868](#868)
- MATCH function fix (value search by type, stop search when match_type=-1 and unordered element encountered) [#1116](#1116)
- Fix `getCalculatedValue()` error with more than two INDIRECT [#1115](#1115)
- Writer\Html did not hide columns [#985](#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants