Support numeric condition in SUMIF, SUMIFS, AVERAGEIF, COUNTIF, MAXIF…

… and MINIF Fixes #683 Fixes #701
PHPOffice · Oct 28, 2018 · ed6a3a0 · ed6a3a0
1 parent 90bb4df
commit ed6a3a0
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+
+### Fixed
+
+- Support numeric condition in SUMIF, SUMIFS, AVERAGEIF, COUNTIF, MAXIF and MINIF [#683](https://github.com/PHPOffice/PhpSpreadsheet/issues/683)
+
 ## [1.5.0] - 2018-10-21
 
 ### Added

diff --git a/src/PhpSpreadsheet/Calculation/Functions.php b/src/PhpSpreadsheet/Calculation/Functions.php
@@ -267,7 +267,7 @@ public static function isCellValue($idx)
     public static function ifCondition($condition)
     {
         $condition = self::flattenSingleValue($condition);
-        if (!isset($condition[0])) {
+        if (!isset($condition[0]) && !is_numeric($condition)) {
             $condition = '=""';
         }
         if (!in_array($condition[0], ['>', '<', '='])) {

diff --git a/tests/data/Calculation/MathTrig/SUMIF.php b/tests/data/Calculation/MathTrig/SUMIF.php
@@ -70,5 +70,28 @@
             [10],
         ],
     ],
-
+    [
+        100,
+        [
+            ['0'],
+            ['some text'],
+        ],
+        0, // Compare integer with string
+        [
+            [100],
+            [1],
+        ],
+    ],
+    [
+        100,
+        [
+            [0],
+            ['some text'],
+        ],
+        0, // Compare integer with integer
+        [
+            [100],
+            [1],
+        ],
+    ],
 ];