Use assertInstanceOf (#286)

PHPOffice · Dec 6, 2017 · dfcab0c · dfcab0c
1 parent 8041a87
commit dfcab0c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/tests/PhpSpreadsheetTests/Cell/HyperlinkTest.php b/tests/PhpSpreadsheetTests/Cell/HyperlinkTest.php
@@ -24,7 +24,7 @@ public function testSetUrl()
 
         $testInstance = new Hyperlink($initialUrlValue);
         $result = $testInstance->setUrl($newUrlValue);
-        self::assertTrue($result instanceof Hyperlink);
+        self::assertInstanceOf(Hyperlink::class, $result);
 
         $result = $testInstance->getUrl();
         self::assertEquals($newUrlValue, $result);
@@ -47,7 +47,7 @@ public function testSetTooltip()
 
         $testInstance = new Hyperlink(null, $initialTooltipValue);
         $result = $testInstance->setTooltip($newTooltipValue);
-        self::assertTrue($result instanceof Hyperlink);
+        self::assertInstanceOf(Hyperlink::class, $result);
 
         $result = $testInstance->getTooltip();
         self::assertEquals($newTooltipValue, $result);

diff --git a/tests/PhpSpreadsheetTests/Chart/DataSeriesValuesTest.php b/tests/PhpSpreadsheetTests/Chart/DataSeriesValuesTest.php
@@ -19,7 +19,7 @@ public function testSetDataType()
 
         foreach ($dataTypeValues as $dataTypeValue) {
             $result = $testInstance->setDataType($dataTypeValue);
-            self::assertTrue($result instanceof DataSeriesValues);
+            self::assertInstanceOf(DataSeriesValues::class, $result);
         }
     }
 

diff --git a/tests/PhpSpreadsheetTests/Chart/LayoutTest.php b/tests/PhpSpreadsheetTests/Chart/LayoutTest.php
@@ -14,7 +14,7 @@ public function testSetLayoutTarget()
         $testInstance = new Layout();
 
         $result = $testInstance->setLayoutTarget($LayoutTargetValue);
-        self::assertTrue($result instanceof Layout);
+        self::assertInstanceOf(Layout::class, $result);
     }
 
     public function testGetLayoutTarget()