Upgrade Dompdf, Tcpdf, Composer Package

PHPOffice · Dec 8, 2024 · bb4b75d · bb4b75d
1 parent 345b63a
commit bb4b75d
Show file tree

Hide file tree

Showing 7 changed files with 124 additions and 143 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -3,14 +3,18 @@
 /.gitattributes export-ignore
 /.github export-ignore
 /.gitignore export-ignore
-/.php_cs.dist export-ignore
+/.phpcs.xml.dist export-ignore
+/.php-cs-fixer.dist export-ignore
 /.scrutinizer.yml export-ignore
 /CHANGELOG.PHPExcel.md export-ignore
 /bin export-ignore
 /composer.lock export-ignore
 /docs export-ignore
 /infra export-ignore
 /mkdocs.yml export-ignore
+/phpstan.neon.dist export-ignore
+/phpstan-baseline.neon export-ignore
+/phpstan-conditional.neon export-ignore
 /phpunit.xml.dist export-ignore
 /samples export-ignore
 /tests export-ignore
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,11 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com)
 and this project adheres to [Semantic Versioning](https://semver.org).
 
-## 1.29.6 - TBD
+## 1.29.6 - 2024-12-08
 
 ### Fixed
 
 - Fix Minor Break Handling Drawings. Backport of [PR #4244](https://github.com/PHPOffice/PhpSpreadsheet/pull/4244)
+- Upgrade locked version of Tcpdf (security advisory).
+- Upgrade locked version of Dompdf (Php8.4 compatibility).
+- Remove unnecessary files from Composer package.
 
 ## 1.29.5 - 2024-11-22
 

diff --git a/composer.json b/composer.json
@@ -85,7 +85,7 @@
     },
     "require-dev": {
         "dealerdirect/phpcodesniffer-composer-installer": "dev-main",
-        "dompdf/dompdf": "^1.0 || ^2.0",
+        "dompdf/dompdf": "^1.0 || ^2.0 || ^3.0",
         "friendsofphp/php-cs-fixer": "^3.2",
         "mitoteam/jpgraph": "^10.3",
         "mpdf/mpdf": "^8.1.1",

diff --git a/composer.lock b/composer.lock
diff --git a/src/PhpSpreadsheet/Helper/Sample.php b/src/PhpSpreadsheet/Helper/Sample.php
@@ -8,7 +8,6 @@
 use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
 use PhpOffice\PhpSpreadsheet\Writer\IWriter;
-use PhpOffice\PhpSpreadsheet\Writer\Pdf\Dompdf;
 use RecursiveDirectoryIterator;
 use RecursiveIteratorIterator;
 use RecursiveRegexIterator;
@@ -138,11 +137,7 @@ public function write(Spreadsheet $spreadsheet, $filename, array $writers = ['Xl
                 $writerCallback($writer);
             }
             $callStartTime = microtime(true);
-            if (PHP_VERSION_ID >= 80400 && $writer instanceof Dompdf) {
-                @$writer->save($path);
-            } else {
-                $writer->save($path);
-            }
+            $writer->save($path);
             $this->logWrite($writer, $path, /** @scrutinizer ignore-type */ $callStartTime);
             if ($this->isCli() === false) {
                 echo '<a href="/download.php?type=' . pathinfo($path, PATHINFO_EXTENSION) . '&name=' . basename($path) . '">Download ' . basename($path) . '</a><br />';

diff --git a/tests/PhpSpreadsheetTests/Functional/StreamTest.php b/tests/PhpSpreadsheetTests/Functional/StreamTest.php
@@ -6,12 +6,6 @@
 use PhpOffice\PhpSpreadsheet\Spreadsheet;
 use PHPUnit\Framework\TestCase;
 
-/**
- * Not clear that Dompdf will be Php8.4 compatible in time.
- * Run in separate process and add version test till it is ready.
- *
- * @runTestsInSeparateProcesses
- */
 class StreamTest extends TestCase
 {
     public static function providerFormats(): array
@@ -46,11 +40,7 @@ public function testAllWritersCanWriteToStream(string $format): void
         } else {
             self::assertSame(0, $stat['size']);
 
-            if ($format === 'Dompdf' && PHP_VERSION_ID >= 80400) {
-                @$writer->save($stream);
-            } else {
-                $writer->save($stream);
-            }
+            $writer->save($stream);
 
             self::assertIsResource($stream, 'should not close the stream for further usage out of PhpSpreadsheet');
             $stat = fstat($stream);