Skip to content

Commit

Permalink
Attempt to provide allow failure for PHP8.1 unit tests (#1847)
Browse files Browse the repository at this point in the history
* Attempt to provide allow failure for PHP8.1 unit tests
  PHP8.1 Tests show as passed despite the errors, and it requires checking the actual output from the run to see what the rea result is; but I can live with that until github provides functionality for a proper allow_failure option
  • Loading branch information
Mark Baker authored Feb 12, 2021
1 parent 6f6a058 commit 17f405c
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,17 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
experimental:
- false
php-version:
- '7.2'
- '7.3'
- '7.4'
- '8.0'
- '8.1'

include:
- php-version: '8.1'
experimental: true

name: PHP ${{ matrix.php-version }}

Expand Down Expand Up @@ -52,8 +57,10 @@ jobs:
- name: Setup problem matchers for PHPUnit
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

- name: Test with PHPUnit
run: ./vendor/bin/phpunit
- name: "Run PHPUnit tests (Experimental: ${{ matrix.experimental }})"
env:
FAILURE_ACTION: "${{ matrix.experimental == true }}"
run: vendor/bin/phpunit --verbose || $FAILURE_ACTION

php-cs-fixer:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 17f405c

Please sign in to comment.