Remove legacy PHPOffice/Common package, fix PHP 8.0 compatibility #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red\Microsoft\PasswordEncoder
liborm85
force-pushed
the
drop-common-package
branch
from
a9c6134 to
ea917c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Package PHPOffice/Common is not developed and is not compatible with PHP 8.0.
PhpSpreadsheet is returned back to use
Shareddirectory (see /src/PhpSpreadsheet/Shared). Therefore, it will be a good idea to choose the same path for PHPWord.This PR move classes from Common to Shared directory, remove phpoffice/common package and fixes compatibility with PHP 8.0 from PR PHPOffice/Common#34.
Checklist:
composer run-script check --timeout=0and no errors were reported