Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template processor setValue() improvements #614

Closed
dmitryfar opened this issue Sep 7, 2015 · 1 comment
Closed

Template processor setValue() improvements #614

dmitryfar opened this issue Sep 7, 2015 · 1 comment
Milestone

Comments

@dmitryfar
Copy link

Template processor improvements:

in setValueForPart() method this strings manipulation calls for each document header, footer and main part:

    if (substr($search, 0, 2) !== '${' && substr($search, -1) !== '}') {
        $search = '${' . $search . '}';
    }

    if (!String::isUTF8($replace)) {
        $replace = utf8_encode($replace);
    }

Move it to setValue() method to reduce time of these operations.

@ghost ghost added the Change Request label Sep 10, 2015
@ghost ghost added this to the 0.13.0 milestone Sep 10, 2015
@ghost ghost self-assigned this Sep 10, 2015
ghost pushed a commit that referenced this issue Dec 12, 2015
 Template processor setValue() improvements #614
@ghost
Copy link

ghost commented Dec 12, 2015

Merged. Thank you, guys.

@ghost ghost closed this as completed Dec 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant