This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Added Redis (PHP Extension) support for CachedObjectStore in PHPExcel #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently testing, thanks for the PR.... it's been on my to do list for a while now |
|
I would be happy to start using this feature. Does it need polishing or any additional changes? |
|
@stefandoorn it should be re-submitted against https://github.com/PHPOffice/phpspreadsheet develop branch (implying rebase-ing and codestyle and namespace adaptations). It should also be tested with unit tests. |
|
@PowerKiKi Is that the successor of this library? Or is this one based on that one? |
|
@stefandoorn it is the next version indeed. It's not yet released, but all development happens over there now. |
|
Before rebasing we should wait to see what happens with cache refactoring as planned in PHPOffice/PhpSpreadsheet#3 |
|
This is now obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for cell caching in Redis. This extension (https://github.com/phpredis/phpredis) is required. Predis is not supported right now.