This repository has been archived by the owner on Jan 2, 2019. It is now read-only.
Optimize vlookupSort() #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had lookup array with 70k elements, this tweak made sorting 2 times faster.
|
We should merge this 👍 |
|
@MarkBaker Did you have chance to test this yet? It would be lovely if you can merge this because some office software generate a lot of empty cells and rows. |
|
Merged on my development machine now, and will be committing within the next hour or so.... thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had lookup array with 70k elements, this tweak made sorting 2 times faster.