Skip to content
This repository has been archived by the owner on Jan 2, 2019. It is now read-only.

Commit

Permalink
Bugfix: (IndrekHaav) Work Item GH-212 - Fix for formulae that referen…
Browse files Browse the repository at this point in the history
…ce a sheet whose name begins with a digit:

these were erroneously identified as numeric values, causing the parser to throw an undefined variable error.
  • Loading branch information
Mark Baker committed Nov 18, 2013
1 parent 30459d2 commit 9c6287a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Classes/PHPExcel/Calculation.php
Original file line number Diff line number Diff line change
Expand Up @@ -2738,10 +2738,10 @@ private function _parseFormula($formula, PHPExcel_Cell $pCell = NULL) {
$pCellParent = ($pCell !== NULL) ? $pCell->getWorksheet() : NULL;

$regexpMatchString = '/^('.self::CALCULATION_REGEXP_FUNCTION.
'|'.self::CALCULATION_REGEXP_CELLREF.
'|'.self::CALCULATION_REGEXP_NUMBER.
'|'.self::CALCULATION_REGEXP_STRING.
'|'.self::CALCULATION_REGEXP_OPENBRACE.
'|'.self::CALCULATION_REGEXP_CELLREF.
'|'.self::CALCULATION_REGEXP_NAMEDRANGE.
'|'.self::CALCULATION_REGEXP_ERROR.
')/si';
Expand Down
2 changes: 2 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ Fixed in develop branch for release v1.8.0:
- Bugfix: (RomanSyroeshko) Work Item GH-267 - CHOOSE() returns "#VALUE!" if the 1st entry is chosen
- Bugfix: (Gemorroj) Work Item GH-268 - When duplicating styles, styles shifted by one column to the right
Fix also applied to duplicating conditional styles
- Bugfix: (IndrekHaav) Work Item GH-212 - Fix for formulae that reference a sheet whose name begins with a digit:
these were erroneously identified as numeric values, causing the parser to throw an undefined variable error.
- Feature: (amerov) - Implementation of the Excel HLOOKUP() function
- Feature: (MBaker) - Added "Quote Prefix" to style settings (Excel2007 Reader and Writer only)
- Feature: (MBaker) - Added Horizontal FILL alignment for Excel5 and Excel2007 Readers/Writers, and Horizontal DISTRIBUTED alignment for Excel2007 Reader/Writer
Expand Down

0 comments on commit 9c6287a

Please sign in to comment.