Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan depth as parameter #45

Closed
AlexSkrypnyk opened this issue Jan 15, 2018 · 3 comments
Closed

Scan depth as parameter #45

AlexSkrypnyk opened this issue Jan 15, 2018 · 3 comments
Assignees
@Potherca
Labels
feature request
Milestone
Release v0.5.0

Comments

@AlexSkrypnyk
Copy link

Problem/Motivation

This is feature request.

Current scan depth is set to less then 4. This may not work for cases when ruleset.xml is provided in the package that contains multiple rulesets - such package would use additional parent directory to hold multiple rulesets.

Exposing scan depth to be extracted from extra section would allow more granular per-project config.
Potherca added a commit that referenced this issue Feb 1, 2018
@Potherca
Adds the ability to set the max depth from the composer.json file
ec63bcd 
Fixes #45
Potherca added a commit that referenced this issue Feb 1, 2018
@Potherca
Adds the ability to set the max depth from the composer.json file
fde5dcc 
Fixes #45
@Potherca Potherca self-assigned this Feb 1, 2018
@Potherca Potherca mentioned this issue Feb 1, 2018
Merged
@Potherca
Copy link
Member

Potherca commented Feb 1, 2018

Thank you for taking the time to report this, my apologies for the slow response (we try to respond within a week).

I have opened a pull-request implemented this, if @frenck agrees with the implementation, I am not opposed to adding this feature.

Potherca added a commit that referenced this issue Feb 1, 2018
@Potherca
Adds the ability to set the max depth from the composer.json file
99d1bdb 
Fixes #45
@Potherca
Copy link
Member

@frenck Ping?

frenck pushed a commit that referenced this issue Oct 25, 2018
@Potherca @frenck
Adds the ability to set the max depth from the composer.json file
7a6d916 
Fixes #45
frenck pushed a commit that referenced this issue Oct 25, 2018
@Potherca @frenck
Adds the ability to set the max depth from the composer.json file (#46)
eaef5f5 
* Adds the ability to set the max depth from the composer.json file

Fixes #45

* 📚 Adds method descriptions to code docs

* 🚜 Tweaks getMinDepth

* 🚜 Reduces amount of logic

* 🚜 Change error message const name for consistency

* 📚 Adds documentation for search depth customization

* 🚜 Renames extra option to phpcodesniffer-search-depth

* 🚑 Fixes default search depth (which was actually 3, not 4)

* 🚑 Corrected PHP doc return type
@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

This feature has been added @alexdesignworks, thanks to @Potherca!

Will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Potherca Potherca

Labels
feature request
Projects
None yet
Milestone
Release v0.5.0
Development

No branches or pull requests
3 participants
@frenck @Potherca @AlexSkrypnyk