4.0 | Zend.Debug.CodeAnalyzer: remove sniff #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
phpcs-4.x/remove-external-tooling-sniffs
branch
from
feb27d9
to
1ce2237
Compare
jrfnl
force-pushed
the
phpcs-4.x/remove-external-tooling-sniffs
branch
from
1ce2237
to
87c22c8
Compare
jrfnl
force-pushed
the
phpcs-4.x/remove-external-tooling-sniffs
branch
from
87c22c8
to
3148a61
Compare
|
@weierophinney Just checking - have you got an opinion on this proposed sniff removal ? |
|
@jrfnl Go for it. We've been actively steering customers to XDebug for years, as (a) Zend Debugger was only ever supported in Zend Studio, and (b) Zend Studio was last actively developed in the PHP 7.1/7.2 timeline, making it irrelevant to most users regardless. |
|
@weierophinney Thank you for confirming what I suspected. I will go ahead and soft deprecate this in 3.9.0, hard deprecate in the last 3.x minor and remove in 4.0. |
13 tasks
I have the impression that the Zend Code Analyzer tool as stand-alone tool is no longer available. Please correct me if I'm wrong. I propose to remove the sniff which allowed for running that tool via PHPCS in PHPCS 4.0, along the same lines as was already done for external JS/CSS tools in commit ea52e7b.
jrfnl
force-pushed
the
phpcs-4.x/remove-external-tooling-sniffs
branch
from
3148a61
to
7c4e829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreation of upstream PR squizlabs/PHP_CodeSniffer#3802:
Suggested changelog entry
The
Zend.Debug.CodeAnalyzersniff has been removed