Generic/DisallowSpaceIndent: flag heredoc/nowdoc closer using space indent #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
…ndent This is the same fix for the `Generic.WhiteSpace.DisallowSpaceIndent` sniff as was previously made in squizlabs/PHP_CodeSniffer 3640 and 533 for the sister-sniff `Generic.WhiteSpace.DisallowTabIndent`. --- Since PHP 7.3, heredoc/nowdoc closers may be indented. This indent can use either tabs or spaces and the indent is included in the `T_END_HEREDOC`/`T_END_NOWDOC` token contents as received from the PHP native tokenizer. However, these tokens were not included in the tokens to look at for the `Generic.WhiteSpace.DisallowSpaceIndent` sniff, which could lead to false negatives. Fixed now, includes tests. And along the same lines as per 533: * The error for space indentation of heredoc/nowdoc closers is not auto-fixable to prevent the fixer creating parse errors as the indentation of the _contents_ of the heredoc/nowdoc has to be the same as for the closer. * The error for space indentation of heredoc/nowdoc closers has its own error code to allow for selectively ignoring the indentation of heredoc/nowdoc closers.
jrfnl
force-pushed
the
feature/generic-disallowspaceindent-flag-heredocnowdoc-indent
branch
from
27714f5 to
6d6cd7c
Compare
jrfnl
deleted the
feature/generic-disallowspaceindent-flag-heredocnowdoc-indent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same fix for the
Generic.WhiteSpace.DisallowSpaceIndentsniff as was previously made in squizlabs/PHP_CodeSniffer#3640 and #533 for the sister-sniffGeneric.WhiteSpace.DisallowTabIndent.Since PHP 7.3, heredoc/nowdoc closers may be indented. This indent can use either tabs or spaces and the indent is included in the
T_END_HEREDOC/T_END_NOWDOCtoken contents as received from the PHP native tokenizer.However, these tokens were not included in the tokens to look at for the
Generic.WhiteSpace.DisallowSpaceIndentsniff, which could lead to false negatives.Fixed now, includes tests.
And along the same lines as per #533:
Suggested changelog entry
Generic.WhiteSpace.DisallowSpaceIndent not reporting errors for PHP 7.3 flexible heredoc/nowdoc syntax
Related issues/external references
Types of changes