Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PHPCSExtra 1.1.2 #275

Merged
merged 8 commits into from
Sep 20, 2023
Merged

Release PHPCSExtra 1.1.2 #275

merged 8 commits into from
Sep 20, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 20, 2023

Release checklist

General

  • Verify, and if necessary, update the allowed version ranges for various dependencies in the composer.json - N/A
  • Add changelog for the release - PR Changelog for PHPCSExtra 1.1.2 #273
    ✏️ Remember to add a release link at the bottom!
  • Update sniff list in README (if applicable) - N/A

Release

  • Merge this PR
  • Make sure all CI builds are green.
  • Tag and create a release (careful, GH defaults to develop!) & copy & paste the changelog to it.
    ✏️ Check if anything from the link collection at the bottom of the changelog needs to be copied in!
  • Make sure all CI builds are green.
  • Close the milestone
  • Open a new milestone for the next release
  • If any open PRs/issues which were milestoned for this release did not make it into the release, update their milestone.
  • Fast-forward develop to be equal to stable

Publicize

  • Tweet about the release.

dependabot bot and others added 8 commits September 11, 2023 01:49
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…/actions/checkout-4

GH Actions: Bump actions/checkout from 3 to 4
…e constructors in namespaced classes

Methods with the same name as a class are not recognized as PHP4-style constructors in namespaced classes.

This was so far not taken into account in this sniff, leading to false positives.

A better solution, with a lower performance impact is expected at a later point in time (namespace tracker), however, as my time is limited, it may still be a while before that solution is available.

In the mean time, let's just fix it.

Includes test.
…ructorreturn-allow-for-namespaced-classes

CodeAnalysis/ConstructorDestructorReturn: correctly ignore PHP-4-style constructors in namespaced classes
The Remark check is failing (again) for some unfathomable reason. They must have changed something downstream again.

Let's see if this fixes it.
Remark check: update config and minor tweak
@jrfnl jrfnl added this to the 1.1.2 milestone Sep 20, 2023
@jrfnl jrfnl merged commit 746c319 into stable Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant