DX: store cache to file only if content will get modified (#7151)

PHP-CS-Fixer · Jul 15, 2023 · 3b398f6 · 3b398f6
1 parent 1d63a8a
commit 3b398f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Cache/FileCacheManager.php b/src/Cache/FileCacheManager.php
@@ -44,6 +44,8 @@ final class FileCacheManager implements CacheManagerInterface
 
     private int $writeCounter = 0;
 
+    private bool $signatureWasUpdated = false;
+
     /**
      * @var CacheInterface
      */
@@ -65,7 +67,9 @@ public function __construct(
 
     public function __destruct()
     {
-        $this->writeCache();
+        if (true === $this->signatureWasUpdated || 0 !== $this->writeCounter) {
+            $this->writeCache();
+        }
     }
 
     /**
@@ -119,6 +123,7 @@ private function readCache(): void
 
         if (null === $cache || !$this->signature->equals($cache->getSignature())) {
             $cache = new Cache($this->signature);
+            $this->signatureWasUpdated = true;
         }
 
         $this->cache = $cache;

diff --git a/tests/Cache/FileCacheManagerTest.php b/tests/Cache/FileCacheManagerTest.php
@@ -91,7 +91,7 @@ public function testCreatesCacheIfCachedSignatureIsDifferent(): void
         unset($manager);
     }
 
-    public function testUsesCacheIfCachedSignatureIsEqual(): void
+    public function testUsesCacheIfCachedSignatureIsEqualAndNoFileWasUpdated(): void
     {
         $cachedSignature = $this->prophesize(SignatureInterface::class)->reveal();
 
@@ -105,7 +105,7 @@ public function testUsesCacheIfCachedSignatureIsEqual(): void
 
         $handlerProphecy = $this->prophesize(FileHandlerInterface::class);
         $handlerProphecy->read()->shouldBeCalled()->willReturn($cache);
-        $handlerProphecy->write(Argument::is($cache))->shouldBeCalled();
+        $handlerProphecy->write(Argument::is($cache))->shouldNotBeCalled();
         $handler = $handlerProphecy->reveal();
 
         $manager = new FileCacheManager(
@@ -267,7 +267,7 @@ public function testSetFileSetsHashOfFileContent(): void
         $handlerProphecy = $this->prophesize(FileHandlerInterface::class);
         $handlerProphecy->read()->willReturn($cache);
         $handlerProphecy->getFile()->willReturn($cacheFile);
-        $handlerProphecy->write(Argument::is($cache));
+        $handlerProphecy->write(Argument::is($cache))->shouldBeCalled();
         $handler = $handlerProphecy->reveal();
 
         $manager = new FileCacheManager(