Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnknownActivityAborted session #95

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

1nf0rmagician
Copy link
Member

The new type is a session-wrapper for activities that should be aborted, but for which the session is unknown for a cell. It can be created and uses a new session context.

Note: Adding the feature in the support only release simplifies bug fixes in downstream projects. This is the only reason for this exception

@1nf0rmagician 1nf0rmagician added the enhancement New feature or request label Nov 29, 2024
@1nf0rmagician 1nf0rmagician self-assigned this Nov 29, 2024
@1nf0rmagician
Copy link
Member Author

FYI: @dacky179

Copy link
Member

@Toxantron Toxantron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

The new type is a session-wrapper for activities that should be aborted, but for which the session is unknown for a cell. It can be created and uses a new session context.
@1nf0rmagician 1nf0rmagician force-pushed the feature/unknown-activity-aborted branch from 73fcffd to 1f8a5b6 Compare December 2, 2024 08:36
@Toxantron Toxantron merged commit 3a172ec into release/4 Dec 2, 2024
1 check passed
@Toxantron Toxantron deleted the feature/unknown-activity-aborted branch December 2, 2024 10:03
@1nf0rmagician 1nf0rmagician restored the feature/unknown-activity-aborted branch December 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants