Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IEditableObject interface and behavior #40

Merged

Conversation

1nf0rmagician
Copy link
Member

Add IEditableObject Interface and update methods to the EntryViewModel to close #38.

For compatibility reasons the direct access to the value of the Entry property is maintained. Therefore, the update mechanism requires a helper variable.

Also the ObservableCollectionWrapper is removed, as it is used in the EntryViewModel exclusively and its functionality can be replaced with a single Select statement.

@1nf0rmagician 1nf0rmagician added the bug Something isn't working label Dec 22, 2021
@1nf0rmagician 1nf0rmagician self-assigned this Dec 22, 2021
@1nf0rmagician 1nf0rmagician force-pushed the feature/EditableEntryViewModel branch from d4815ee to d2e0c84 Compare December 22, 2021 06:40
@Toxantron
Copy link
Member

I like it, downwards compatible fix :-)

@1nf0rmagician 1nf0rmagician force-pushed the feature/EditableEntryViewModel branch from d2e0c84 to 502f6d0 Compare December 22, 2021 09:23
@1nf0rmagician 1nf0rmagician force-pushed the feature/EditableEntryViewModel branch from 502f6d0 to 9b03b29 Compare December 22, 2021 10:32
@dbeuchler dbeuchler added this to the ClientFramework 3.2 milestone Dec 22, 2021
@dbeuchler dbeuchler added the enhancement New feature or request label Dec 22, 2021
@dbeuchler dbeuchler merged commit 5d7c49a into PHOENIXCONTACT:dev Dec 22, 2021
@1nf0rmagician 1nf0rmagician deleted the feature/EditableEntryViewModel branch December 22, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support update of EntryViewModel in EntryEditor
3 participants