Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide when to use 'diploid mode' #169

Closed
CuzickA opened this issue Jul 5, 2023 · 18 comments
Closed

Decide when to use 'diploid mode' #169

CuzickA opened this issue Jul 5, 2023 · 18 comments
Assignees

Comments

@CuzickA
Copy link

CuzickA commented Jul 5, 2023

We have recently enabled diploid mode in PHI-Canto and used it to curate a Chemistry paper #127

It would be good to write up some rules and examples of when to use this in our FAQ documentation.

A few points to consider

  1. Are we only going to use this option in the pathogen genotypes for chemistry curation? Would we also use it for any other Pathogen phenotypes or PHI phenotypes associated with the paper?
  2. If a diploid pathogen is used in an expt but the authors only report on homozygous genotypes do we use the haploid or diploid option?
  3. Do we want to extend this option to the host genotypes? The diploid option is currently enabled for host genotypes. This could get really complicated with the different ploidy of different host species.

@ValWood is there currently any guidance on using 'diploid mode'?
@MPiovesana, please go ahead and start thinking about this some more for drafting text in the FAQ document.

@ValWood
Copy link

ValWood commented Jul 5, 2023

The 'diploid' mode is covered in our docs
https://curation.pombase.org/pombe/docs/fypo_annotation#multi-allele-phenotypes
but we don't have any specific curation examples (we presume users will know if they need to sue it).

This was only added fairly recently,
This was the new item:
https://www.pombase.org/news
New diploid genotype & phenotype display
2021-04-29

PomBase now includes pages for curated diploid genotypes, and displays phenotypes annotated to them on gene and publication pages. For more details see the documentation for phenotype annotations and genotype pages.

@MPiovesana

This comment was marked as resolved.

@jseager7

This comment was marked as resolved.

@jseager7

This comment was marked as resolved.

@jseager7

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@jseager7

This comment was marked as resolved.

@jseager7

This comment was marked as resolved.

@MPiovesana
Copy link
Collaborator

The changes have been deployed now so the glitch with creating diploids should be fixed. I'm going to hide this and the previous comments as resolved.

@jseager7 @CuzickA I have briefly tested the 'Create diploid locus' function this afternoon and the glitch has indeed been resolved. Now it is possible to create a heterozygous genotype (mutant allele / wt allele) by selecting the mutant genotype, clicking on 'Created diploid locus', and selecting the option which includes mutant and wt allele. It no longer seems to be necessary to create a wt allele in order to create a diploid heterozygous genotype. Thank you for sorting this out!

@CuzickA
Copy link
Author

CuzickA commented Jul 14, 2023

Thanks @jseager7
Do you foresee any problems displaying these diploid genotypes on the new PHI-base 5 display?

@CuzickA
Copy link
Author

CuzickA commented Jul 14, 2023

Current examples of sessions using diploid mode.
#116
#127

Both are for Candida albicans

@jseager7
Copy link

Do you foresee any problems displaying these diploid genotypes on the new PHI-base 5 display?

They probably won't display correctly. We'll have to discuss this at the next meeting.

@CuzickA
Copy link
Author

CuzickA commented Feb 7, 2024

I am checking another session using diploid mode #188

@jseager7, did we decide whether these could be displayed in PHI5 or whether this would be a future add on to PHI5 after the initial launch?

@jseager7
Copy link

jseager7 commented Feb 7, 2024

I don't think that the PHI-base 5 website currently supports diploid mode and adding support for displaying it on the website would probably require further funding. Unless there's some kind of workaround we can use in the allele name. I'd have to check how PomBase display diploids on their website.

@ValWood
Copy link

ValWood commented Feb 7, 2024

For a lonf time we reported diploid status in the background field. It's quite a lot of work to change display etc if you don't have many diploids to annotate.

@jseager7
Copy link

jseager7 commented Feb 7, 2024

We can display the background on our website so that would be a useful workaround, thanks.

@CuzickA
Copy link
Author

CuzickA commented Sep 6, 2024

We can display the background on our website so that would be a useful workaround, thanks.

Hi @jseager7, did the diploid display get resolved in the end? Can we close this ticket?

@jseager7
Copy link

jseager7 commented Sep 9, 2024

We haven't had a chance to test how this works on the website because we haven't made any further releases. I'd need to change the release pipeline to include diploid information in the background as a workaround. Those tasks belong in other trackers though, so I'll close this issue.

@jseager7 jseager7 closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants