Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide and document when species must match in primary annotation and AE #111

Open
CuzickA opened this issue Nov 15, 2022 · 3 comments
Open
Assignees
Labels

Comments

@CuzickA
Copy link

CuzickA commented Nov 15, 2022

It would be good to provide clear guidance on when a species in an AE must match that in the primary annotation.

From ticket #103 we have so far decided that Species must match in GO annotations and protein modifications.

We have suggested that species do not need to match in phenotype primary annotations and AEs.

This could be written up in the Help documentation and/or perhaps species restrictors could be added to PHI-Canto to prevent curators from adding a different species in the AE and primary annotation during GO annotations etc.

@CuzickA
Copy link
Author

CuzickA commented Nov 21, 2022

Maybe add this to PHI-base/canto-docs#10

@CuzickA
Copy link
Author

CuzickA commented Jan 24, 2023

Suggestion in #106 that for GO annotations annotating results for a PHI eg the effects of an effector on a host protein, it is ok to have the host protein in the AE and vice versa for host protein having an effect on a pathogen protein. Needs to make biological sense rather than some non-biological mixing of species in some assay system (which would be incorrect) eg in #103 with tobacco and maize.

@CuzickA CuzickA added the Future label Sep 6, 2024
@CuzickA
Copy link
Author

CuzickA commented Sep 6, 2024

Hi @jseager7, just tagging you in this ticket in case the team feels that it is worth noting this in the PHI-Canto Help or future FAQ document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants